Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Get custom colors #27

Closed
Jared0430 opened this issue Sep 7, 2019 · 10 comments
Closed

[Feature Request] Get custom colors #27

Jared0430 opened this issue Sep 7, 2019 · 10 comments
Labels
enhancement New feature or request

Comments

@Jared0430
Copy link

It would be great if we could get the player chosen colors either in the status object, or better yet when the song starts with the colors for that level (taking into account the environment)

@Bogo-Sort
Copy link

I wanted to ask the same

@opl- opl- added the enhancement New feature or request label Jan 11, 2020
@LeoDJ
Copy link

LeoDJ commented Dec 27, 2020

Yes, this would be greatly appreciated. I'm currently in the process of writing a Beatsaber lighting events to LED lighting bridge and not having custom colors really limits the functionality ^^'

@Protected
Copy link
Contributor

Came here to ask for this, surprised it has such an old ticket. This would be very useful in the StatusObject.

@codingcatgirl
Copy link

Looking for this as well! Including the custom colors if they have been overridden by a map using Chromapper etc… https://bsmg.wiki/mapping/basic-lighting.html#map-color-overrides

@opl-
Copy link
Owner

opl- commented Sep 24, 2021

Added in f093556, released in v1.18.0. Also works with SongCore color overrides.

@opl- opl- closed this as completed Sep 24, 2021
@codingcatgirl
Copy link

Holy shit, thanks!

Isn't there also something that allows overwriting the colors of single notes? I might be mistaken. It could be interesting to just put the custom_json_data stuff directly in the websocket output :)

@opl-
Copy link
Owner

opl- commented Sep 24, 2021

While implementing this I had a friend mention as a joke that putting it as part of beatmap should be fine unless some mod allows going through all the colors of a rainbow. I hate that this joke turned out to be a reality. Completely forgot about Chroma.

I'll just say that for now the way the mod is written and the protocol designed makes it difficult to allow optional mods and extra data to be sent out over the WebSocket while keeping it reasonably clean and easy to use.

I'm not entirely opposed to exposing _customData as it would certainly be useful, especially for tinkering. I'll think about whether this is a good idea and if there's a decent solution for the changing environment colors problem.

@codingcatgirl
Copy link

Okay, no hurry! Thanks for your work so far <3

@Protected
Copy link
Contributor

Ooo, now I have to actually make the widget I wanted. I'll let you know when I have a link for the list.

@codingcatgirl
Copy link

Since i'm just tinkering with this again, i felt like i might comment on here that this is still an open issue. Could be worth reopening it ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants