-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"songStart" Event is not fired for certain Mod-Scores #61
Comments
Possibly related to #59 |
Please send a game log from a session where this happened. I'm unfortunately still unable to launch the game so unless someone else takes this that's the best I can do here. |
This should be the log where I tested 1.15.1 of BeatSaberHTTP for the other bug I had reported. I first tried a song where the Event triggered just fine, and then as a second song I tested "Up & Down", which as mentioned in the OP is broken regarding the Event. Oh... I only bothered to check the link in your post after I had posted this |
Had some time yesterday to record a verbose log. |
Here's a test build that should fix this issue (if my guess on which part is breaking is right): BeatSaberHTTPStatus-1.15.1-dev-bs1.14.0-c005394e.zip (code in fix/61). Here's an alternate fix in case the previous one doesn't work: BeatSaberHTTPStatus-1.15.1-dev-bs1.14.0-5015c408.zip (code in 5015c40). I'm leaving the issue open as I'm not sure if this is the right way to fix this. I'd have to do practical testing to see how Noodle Extensions modifies the data. |
I just tried the first Dev-Build you've attached (the one from Branch fix/61) and everything seems to be working fine. I've ran through a couple of songs (both NE and not with and without Lawless) and HTTP Status worked as intended. Just in case I've attached another log file here: |
Current behavior
Certain mod-scores don't trigger the song start event.
It is possible that this is an issue with Noodle Extensions, as I've only encountered the issue with Maps using this mod, but not all Noodle Extension scores are broken in this way.
Pretty much all NE-maps I've tried with a Laweless Difficulty did not trigger the event, but if my memory serves me right, there was one more map in my collection that had the same behavior without having a Laweless difficulty.
Expected behavior
Event songStart should be triggered for all songs when the user clicks on play.
Reproduction steps
Environment
BeatSaber version: 1.14.0
HTTP Status version: 1.15.0 & 1.15.1
Platform: Index, Windows 10 20H2
The text was updated successfully, but these errors were encountered: