Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel build support for Windows [Probably blocked: #3024] #3371

Open
rt4914 opened this issue Jun 23, 2021 · 8 comments
Open

Bazel build support for Windows [Probably blocked: #3024] #3371

rt4914 opened this issue Jun 23, 2021 · 8 comments
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jun 23, 2021

Currently the project does not work with bazel-build on Windows operating system. This needs to be fixed considering the contributors are generally students with Windows operating system and they are willing to contribute but this restricts there contribution to minor code changes.

Also this is really important from next year's GSoC point of view too before which we see a good number of contributors.

@rt4914
Copy link
Contributor Author

rt4914 commented Jun 23, 2021

cc: @fsharpasharp

@BenHenning
Copy link
Member

@rt4914 do you have context on what's going on here? We know that the Android Studio plugin may not work in Windows but the build itself should work in theory. What problems have contributors reported having?

@BenHenning
Copy link
Member

Hmm. Trying to build locally and I ran into bazel-contrib/rules_jvm_external#288. Unfortunately, that issue was closed without a clear resolution, so it may be the case that the build won't work locally with native windows. I'm going to keep poking around, but the alternative might be to use a Unix subsystem on Windows or a VM.

@BenHenning
Copy link
Member

So I've finally gotten a Windows build working. Double checking that Robolectric & JUnit tests pass. Unfortunately, it requires using a Unix subsystem instead of native Windows--I suspect we'll need to work with the Bazel team to try and get the Windows build working. This should be a reasonable stop-gap, though having Windows Android Studio installed with Ubuntu-based Bazel for building may be confusing. This is probably best as a stop-gap until we can get fixes in the build pipeline for Windows.

@BenHenning
Copy link
Member

https://github.com/oppia/oppia-android/wiki/Bazel-Setup-Instructions-for-Windows is now live. @rt4914 can you verify with the contributors whether these instructions help unblock them?

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Jul 7, 2021
@BenHenning
Copy link
Member

Took a while, but confirming that all command line-compatible tests seem to pass on the subsystem.

@rt4914
Copy link
Contributor Author

rt4914 commented Jul 8, 2021

@BenHenning I will inform about this to the contributors.

@BenHenning
Copy link
Member

I have a slight suspicion that we need to resolve #3024 before this since the above issue & PR linked from that issue implied that there may be an aapt2 incompatibility that gets resolved in 30.+.

@BenHenning BenHenning changed the title Bazel build support for Windows Bazel build support for Windows [Probably blocked: #3024] Oct 12, 2021
@rt4914 rt4914 removed their assignment Jan 18, 2022
@BenHenning BenHenning added this to the Beta MR2 milestone Jun 11, 2022
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). issue_type_enhancement Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. and removed issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 15, 2022
@BenHenning BenHenning added Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_developer labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Development

No branches or pull requests

4 participants