Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure entire license text is displayed for all the copyright licenses #3738

Open
prayutsu opened this issue Aug 26, 2021 · 7 comments
Open
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@prayutsu
Copy link
Contributor

Reference Link - https://stackoverflow.com/a/51733275/12215015

We cannot have a string that is larger than 32,767 bytes (encoded in UTF-8) in your APK file but some license texts (like CDDL + GPLv2 license) that are generated by running the RetrieveLicenseTexts.kt script are larger than 32,767 bytes so they can not be displayed directly in the UI and we only show the license link in these cases.

We should display the license texts whenever possible and hence we need another solution to support displaying large license texts.

Potential solutions

  1. Rather than storing the license texts in the third_party_dependencies.xml file, we can store them in a textproto file and parse the textproto file to display the license texts.

  2. Rather than storing the license text in a single string, we can split the license text before the first whitespace character before the max_limit_of_chars store the text in an array of strings. We can then concatenate all the strings of the array while displaying the license texts in the UI.

@BenHenning BenHenning added this to the Beta MR2 milestone Jun 11, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner and removed issue_type_infrastructure labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@BenHenning
Copy link
Member

To clarify point (1), we'd need to load texts into a .pb file and load that from the app's assets directory. That could work as a drop-in replacement for using string resources in a way that avoids the limit, though we'd need some additional piping through the domain layer.

@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added Hacktoberfest This is a suggested Hacktoberfest issue. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Aug 10, 2023
@adhiamboperes adhiamboperes added the good first issue This item is good for new contributors to make their pull request. label Oct 17, 2023
@adhiamboperes adhiamboperes removed the Hacktoberfest This is a suggested Hacktoberfest issue. label Nov 27, 2023
@dmdbilal
Copy link

dmdbilal commented Jan 6, 2024

If this issue still open, Shall i work on it ?

@adhiamboperes
Copy link
Collaborator

If this issue still open, Shall i work on it ?

Hi,
Please submit an overview of your proposed solution. You can also create a draft PR for this.

@TanishMoral11
Copy link
Collaborator

HEY @adhiamboperes
If this issue still open, Shall i work on it ?

@adhiamboperes
Copy link
Collaborator

Hi @TanishMoral11, yes the issue is still open, and we'd like to hear your proposed solution, if it sounds good, we'll assign it to you and you can create a PR.

@TanishMoral11
Copy link
Collaborator

Hi @adhiamboperes , thank you for the response!

Here’s my proposed solution:

File Identification: I’ll focus on DragDropSortInteractionView.kt and DragDropSortInteractionViewModel.kt . These files are responsible for the UI and logic of drag-and-drop interactions.

Logic Update: I'll improve the drag-and-drop handling by updating the onDragEvent method in DragDropSortInteractionView.kt to ensure proper reordering and syncing with the ViewModel.

Let me know if this approach works for you, and I’ll start implementing it.

Thanks!

@adhiamboperes
Copy link
Collaborator

@TanishMoral11, it looks like you may have posted the proposed solution under the wrong issue thread. PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

9 participants