-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure entire license text is displayed for all the copyright licenses #3738
Comments
To clarify point (1), we'd need to load texts into a .pb file and load that from the app's assets directory. That could work as a drop-in replacement for using string resources in a way that avoids the limit, though we'd need some additional piping through the domain layer. |
If this issue still open, Shall i work on it ? |
Hi, |
HEY @adhiamboperes |
Hi @TanishMoral11, yes the issue is still open, and we'd like to hear your proposed solution, if it sounds good, we'll assign it to you and you can create a PR. |
Hi @adhiamboperes , thank you for the response! Here’s my proposed solution: File Identification: I’ll focus on DragDropSortInteractionView.kt and DragDropSortInteractionViewModel.kt . These files are responsible for the UI and logic of drag-and-drop interactions. Logic Update: I'll improve the drag-and-drop handling by updating the onDragEvent method in DragDropSortInteractionView.kt to ensure proper reordering and syncing with the ViewModel. Let me know if this approach works for you, and I’ll start implementing it. Thanks! |
@TanishMoral11, it looks like you may have posted the proposed solution under the wrong issue thread. PTAL. |
Reference Link - https://stackoverflow.com/a/51733275/12215015
We cannot have a string that is larger than 32,767 bytes (encoded in UTF-8) in your APK file but some license texts (like
CDDL + GPLv2
license) that are generated by running theRetrieveLicenseTexts.kt
script are larger than 32,767 bytes so they can not be displayed directly in the UI and we only show the license link in these cases.We should display the license texts whenever possible and hence we need another solution to support displaying large license texts.
Potential solutions
Rather than storing the license texts in the third_party_dependencies.xml file, we can store them in a textproto file and parse the textproto file to display the license texts.
Rather than storing the license text in a single string, we can split the license text before the first whitespace character before the
max_limit_of_chars
store the text in an array of strings. We can then concatenate all the strings of the array while displaying the license texts in the UI.The text was updated successfully, but these errors were encountered: