Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Missing App Language Options when app is built with Gradle. #5106

Open
ayush290104 opened this issue Jul 26, 2023 · 8 comments
Open
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@ayush290104
Copy link

Describe the bug

On going to options tab, when selecting App language there is nothing visible in app language fragment.
There should be a list of languages to choose from, but the list is empty.

Steps To Reproduce

Select Options and then click on App Language.

Expected Behavior

It should show list of languages to the user.

Screenshots/Videos

No response

What device/emulator are you using?

Iqoo Z3 5g

Which Android version is your device/emulator running?

Android 13

Which version of the Oppia Android app are you using?

1.0

Additional Context

Oppia android

@ayush290104 ayush290104 added bug End user-perceivable behaviors which are not desirable. triage needed labels Jul 26, 2023
@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Jul 26, 2023

Hi @ayush290104, thanks for reporting this.

By design, this language functionality is not available on Gradle, but you can see it if you build the app with Bazel.

@adhiamboperes
Copy link
Collaborator

That said, I think we can improve the developer UX by either disabling the menu or showing a message when languages are unavailable.

I'm adding this to the developer workflow team since it's a dev specific issue.

@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed triage needed labels Jul 26, 2023
@ayush290104
Copy link
Author

@adhiamboperes Sir actually I am an android developer and I want to contribute to open source can you tell me how to start contributing.
It will be great if you could guide me or assign an issue

@adhiamboperes adhiamboperes changed the title [BUG]: [BUG]: Missing App Language Options when app is built with Gradle. Jul 26, 2023
@dev-divyansh
Copy link

Hey , @adhiamboperes ,
I would like to work on this issue

@adhiamboperes
Copy link
Collaborator

Hi @dev-divyansh, this issue requires a bit of context with the codebase. How would you go about solving it?

@dev-divyansh
Copy link

dev-divyansh commented Jul 27, 2023

Hi @dev-divyansh, this issue requires a bit of context with the codebase. How would you go about solving it?

the associated files with the language screen is : org/oppia/android/app/options/AppLanguageActivityPresenter.kt and the xml file layout/app_language_activity.xml,

I think i can fix it

PS : I am too facing the issue , when running the App on my local device the language screen is blank its not showing any available language options to select

Any suggestions @adhiamboperes

@adhiamboperes
Copy link
Collaborator

Hi @dev-divyansh, this issue requires a bit of context with the codebase. How would you go about solving it?

the associated files with the language screen is : org/oppia/android/app/options/AppLanguageActivityPresenter.kt and the xml file layout/app_language_activity.xml,

I think i can fix it

PS : I am too facing the issue , when running the App on my local device the language screen is blank its not showing any available language options to select

Any suggestions @adhiamboperes

Please refer to my comment above on why this is happening. This issue is a bit complex, and I would suggest that you pick one of our starter issues in order to farmiliarize with the codebase. I would suggest looking at either #3843 or #3841. Please look at the two issues I have proposed and leave a comment on the one you would like to be assigned, describing how you would solve it.

@manas-yu
Copy link
Collaborator

manas-yu commented Dec 7, 2024

That said, I think we can improve the developer UX by either disabling the menu or showing a message when languages are unavailable.

We could disable the "Options" tab by adding a custom flag in build.gradle or gradle.properties and using it to conditionally disable the tab whenever the app is built via Gradle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Development

No branches or pull requests

4 participants