Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI task inference_tests_jdk11 is failling on master #189

Closed
zcai1 opened this issue Aug 27, 2021 · 2 comments
Closed

CI task inference_tests_jdk11 is failling on master #189

zcai1 opened this issue Aug 27, 2021 · 2 comments
Assignees

Comments

@zcai1
Copy link

zcai1 commented Aug 27, 2021

Causes:

  1. In docker image "mdernst/cf-ubuntu-jdk11:latest", module "lithium" is never available.
  2. import lithium in https://github.com/opprop/do-like-javac/blob/3eb4a43521ae181a9b777a589e477b0c6ab7cb6e/do_like_javac/tools/testminimizer.py#L8
  3. git-clone-related kelloggm do-like-javac in
    "${SCRIPTDIR}"/../bin-devel/.plume-scripts/git-clone-related kelloggm do-like-javac "${SCRIPTDIR}"/.do-like-javac

Explanation:
CF uses kelloggm/do-like-javac which works well with all CF builds. Previously, "wpi.sh" clones do-like-javac from kelloggm with hardcoded address. git-clone-related kelloggm do-like-javac, however, will clone the do-like-javac in opprop because it has a branch named "master". The test didn't fail for our PR that made this change because opprop/do-like-javac doesn't have a branch named "eisop-3.17" (so it uses the default branch of kelloggm/do-like-javac). Note that the file "testminimizer.py" doesn't exist in either kelloggm/do-like-javac or SRI-CSL/do-like-javac.

Depending on the purpose of having opprop/do-like-javac, there are several solutions:

  1. Merge latest SRI-CSL/do-like-javac into opprop/do-like-javac
  2. Change the "wpi.sh" script back to cloning the hardcoded kelloggm/do-like-javac repo
  3. Remove opprop/do-like-javac if we no longer need it
@wmdietl
Copy link
Member

wmdietl commented Sep 1, 2021

@zcai1 Thanks for investigating this!

I've created opprop/do-like-javac#18 which pulls in changes that should make the WPI test work.
Can you please try whether the version in that PR works, also for the CFI usages?

The testminimizer is an addition in this version which is documented in README_testminimizer.md. Could you make a PR that adds a reference to README_testminimizer.md from README.md?

Separately I will update the docker image to include lithium.

@wmdietl wmdietl assigned zcai1 and unassigned wmdietl Sep 1, 2021
@Ao-senXiong
Copy link

Closed as this is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants