You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Explanation:
CF uses kelloggm/do-like-javac which works well with all CF builds. Previously, "wpi.sh" clones do-like-javac from kelloggm with hardcoded address. git-clone-related kelloggm do-like-javac, however, will clone the do-like-javac in opprop because it has a branch named "master". The test didn't fail for our PR that made this change because opprop/do-like-javac doesn't have a branch named "eisop-3.17" (so it uses the default branch of kelloggm/do-like-javac). Note that the file "testminimizer.py" doesn't exist in either kelloggm/do-like-javac or SRI-CSL/do-like-javac.
Depending on the purpose of having opprop/do-like-javac, there are several solutions:
Merge latest SRI-CSL/do-like-javac into opprop/do-like-javac
Change the "wpi.sh" script back to cloning the hardcoded kelloggm/do-like-javac repo
Remove opprop/do-like-javac if we no longer need it
The text was updated successfully, but these errors were encountered:
I've created opprop/do-like-javac#18 which pulls in changes that should make the WPI test work.
Can you please try whether the version in that PR works, also for the CFI usages?
The testminimizer is an addition in this version which is documented in README_testminimizer.md. Could you make a PR that adds a reference to README_testminimizer.md from README.md?
Separately I will update the docker image to include lithium.
Causes:
import lithium
in https://github.com/opprop/do-like-javac/blob/3eb4a43521ae181a9b777a589e477b0c6ab7cb6e/do_like_javac/tools/testminimizer.py#L8git-clone-related kelloggm do-like-javac
inchecker-framework/checker/bin/wpi.sh
Line 262 in 6cccf27
Explanation:
CF uses kelloggm/do-like-javac which works well with all CF builds. Previously, "wpi.sh" clones do-like-javac from kelloggm with hardcoded address.
git-clone-related kelloggm do-like-javac
, however, will clone the do-like-javac in opprop because it has a branch named "master". The test didn't fail for our PR that made this change because opprop/do-like-javac doesn't have a branch named "eisop-3.17" (so it uses the default branch of kelloggm/do-like-javac). Note that the file "testminimizer.py" doesn't exist in either kelloggm/do-like-javac or SRI-CSL/do-like-javac.Depending on the purpose of having opprop/do-like-javac, there are several solutions:
The text was updated successfully, but these errors were encountered: