Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[berkshelf] Berkshelf is for Workstations #12

Merged

Conversation

fujin
Copy link

@fujin fujin commented Apr 2, 2013

This makes the Vagrant driver behave more like the LXC driver, relying on the SSH Base semantics set forth in test-kitchen@1.0

I prefer to have berkshelf resolve cookbooks on the workstation -- temporarily install them somewhere, and then have an intermediate system, in this case, TK, ship cookbooks and so-on from a combined, resolved, cookbook directory. Previously Vagrant was trying to interact with Berkshelf on the guest, which would mean that the guest would need to have access to Git, etc

Thoughts? @portertech says this is already WIP by @fnichol ?

I'm still having some trouble with this, but prefer the SSH Base / LXC behavior.. it was much faster.

This makes the Vagrant driver behave more like the LXC driver, relying on the SSH Base semantics set forth in test-kitchen@1.0

I prefer to have berkshelf resolve cookbooks on the workstation -- temporarily install them somewhere, and then have an intermediate system, in this case, TK, ship cookbooks and so-on from a combined, resolved, cookbook directory. Previously Vagrant was trying to interact with Berkshelf on the guest, which would mean that the guest would need to have access to Git, etc
@fnichol
Copy link
Contributor

fnichol commented Apr 2, 2013

I've been leaning in this direction over the last week as this helps keep this driver more in line with all the others. I'm also hoping to speed up the chef artifact uploading (trim down files, concat into tarball or similar) which helps all SSH-based drivers. I'll take another look later today and bug @jtimberman when we meet up tonight.

@fujin
Copy link
Author

fujin commented Apr 2, 2013

Happy to help with testing.

@fujin
Copy link
Author

fujin commented Apr 3, 2013

I'm screwing around with this more -- have added synced folders and made sure that we can talk to vagrant instances without relying on vagrant provision.

The old functionality is enabled with config[:use_vagrant_provision] and config[:use_vagrant_berkshelf_plugin]

I have convergence now with no synced folders and @fnichol Data Uploader / Vagrantfile generator.

@fujin
Copy link
Author

fujin commented Apr 3, 2013

a.k.a Fuck Vagrant and Fuck Berkshelf

@fnichol
Copy link
Contributor

fnichol commented May 1, 2013

So good, this is great!

@fujin, do you have a use for the synced folders? Was surprised to see that part

fnichol added a commit that referenced this pull request May 1, 2013
@fnichol fnichol merged commit 1e74824 into test-kitchen:master May 1, 2013
@fujin
Copy link
Author

fujin commented May 6, 2013

Thanks team! ❤️

@fujin fujin deleted the feature/berkshelf-is-for-workstations branch May 6, 2013 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants