Refactor how we handle loading dirs for software files. #82
+46
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came about because I found myself trying to debug and oddly placed
can't convert nil into String
exception, while attempting to build a project.Turns out I wasn't running omnibus in
bundler
context, so it couldn't load up the gem metadata. In this condition, the error happens when trying to evaluate line 293.Omnibus.omnibus_software_root
wasnil
, hence the boom.I felt that letting it fall through, like there was a problem with the places it looks for the software files, was a reasonable course of action here.
So, this addresses an edge case, and I threw in a silly test for good measure.