Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how we handle loading dirs for software files. #82

Merged
merged 1 commit into from
Dec 6, 2013

Conversation

benjaminws
Copy link
Contributor

This came about because I found myself trying to debug and oddly placed can't convert nil into String exception, while attempting to build a project.

Turns out I wasn't running omnibus in bundler context, so it couldn't load up the gem metadata. In this condition, the error happens when trying to evaluate line 293. Omnibus.omnibus_software_root was nil, hence the boom.

I felt that letting it fall through, like there was a problem with the places it looks for the software files, was a reasonable course of action here.

So, this addresses an edge case, and I threw in a silly test for good measure.

@schisamo
Copy link
Contributor

schisamo commented Dec 4, 2013

@benjaminws You have not been forgotten! Should get around to reviewing/merging this tomorrow.

schisamo added a commit that referenced this pull request Dec 6, 2013
Refactor how we handle loading dirs for software files.
@schisamo schisamo merged commit 7dc4415 into chef:master Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants