Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the sink #111

Merged
merged 3 commits into from
May 11, 2013
Merged

Add the sink #111

merged 3 commits into from
May 11, 2013

Conversation

sethvargo
Copy link
Contributor

No description provided.

@sethvargo
Copy link
Contributor Author

@schisamo @fnichol this is ready for merge, complete with aruba tests for regression.

@reset
Copy link
Contributor

reset commented May 10, 2013

💯

fnichol added a commit that referenced this pull request May 11, 2013
@fnichol
Merge pull request #111 from opscode/sink
808f413 
Add the sink
@fnichol fnichol merged commit 808f413 into master May 11, 2013
@fnichol
Copy link
Contributor

fnichol commented May 11, 2013

Hm, new feature? 😒

It has tests? 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥 💥

:shipit:

tumblr_m6o0wqdnnq1ror01no1_400

@fnichol fnichol deleted the sink branch May 11, 2013 02:58
@sethvargo
Copy link
Contributor Author

👀 :shipit: 👀

❤️

@ekrupnik
Copy link

👍

@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sethvargo @reset @fnichol @ekrupnik @jamtur01 @schisamo @wohali @stevendanna