Require the 'name' attribute is present in metadata.rb
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, good idea. Since Berkshelf requires this now and Foodcritic has rules to catch this I suppose we're okay to follow the lead here |
|
@fnichol right, but it's not being raised. I'm confused... |
| @@ -158,6 +158,9 @@ def cp_cookbooks(tmpdir) | |||
| def cp_this_cookbook(tmpdir) | |||
| metadata_rb = File.join(kitchen_root, "metadata.rb") | |||
| cb_name = MetadataChopper.extract(metadata_rb).first | |||
|
|
|||
| raise TestKitchen::Errors::MissingCookbookName.new(name) if cb_name.nil? | |||
|
|
|||
| cb_path = File.join(tmpdir, cb_name) | |||
There was a problem hiding this comment.
Ah, I bet this is the issue: if cb_name = nil and tmdir = '/tmp/blah' then effectively:
File.join('/tmp/blah', nil) # TypeError: can't convert nil into StringMy bad…
There was a problem hiding this comment.
@fnichol right, but this error isn't actually raising :(
fnichol
added a commit
that referenced
this pull request
May 23, 2013
Require the 'name' attribute is present in `metadata.rb`
fnichol
added a commit
that referenced
this pull request
May 23, 2013
|
Got it, the "nil to String" was happening inside an ensure block. Pinned it down in dbfd3c1 |
|
😄 |
thommay
pushed a commit
to thommay/test-kitchen
that referenced
this pull request
May 30, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fnichol after tracing all day, I found this.
If there's no
nameattribute in themetadata.rb, TK fails to copy the cookbook, but it doesn't fail until later up the stack.So I inserted a check... and it still doesn't fail until later up the stack, but the exception is definitely raised. I think we need to link the supervisor/actors together and listen for exceptions on the children?
Basically, I want to give the user a happy little error say "PUT A NAME ATTRIBUTE IF YOUR FREAKING COOKBOOK", but nicer 😄. And instead I get "Message: Failed to complete #converge action: [can't convert nil into String]"