Swap cookbook resolution strategy from shell outs to using Ruby APIs. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
We're not having any problems with this via the shell-out approach on windows - it's working great right now. Not unreasonable to minimize the fork/exec, but it's not a bad plan. |
fnichol
added a commit
that referenced
this pull request
May 24, 2013
Swap cookbook resolution strategy from shell outs to using Ruby APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver behind this is to minimize the amount of fork+exec that exists in the codebase which will help with platform portability, namely Windows. It should also make capturing dependency resolution errors much easier since they will be Ruby exceptions not shell exit codes.
Currently for Chef, there are 2 external resolvers that ship in Test Kitchen: