Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chef omnibus install.sh url to be configurable #147

Merged
merged 1 commit into from
Aug 29, 2013

Conversation

jrwesolo
Copy link
Contributor

Inside ssh_base.rb, the url for the chef omnibus install.sh is currently hardcoded to https://www.opscode.com/chef/install.sh. This should be configurable to support custom variations that might be needed (such as in a corporate network, etc). This will also allow the possibility of removing an external dependency on opscode.com.

This pull request allows the url to be configured in the .kitchen.yml (example below)

driver config:
  require_chef_omnibus: true
  chef_omnibus_url: "https://example.com/chef/install.sh"

@fnichol
Copy link
Contributor

fnichol commented Jul 17, 2013

Yes, great idea. I'd usually scrub this kind of hard coding sooner or later, so thank you.

Do you have an Opscode CLA signed by chance?

@jrwesolo
Copy link
Contributor Author

My apologies. I set up an email filter and did not see your reply. I just signed up for an Opscode CLA under my same name and email and created the following ticket in jira: http://tickets.opscode.com/browse/KITCHEN-79. Is there anything else needed to be created?

@fnichol fnichol merged commit 628f0fc into test-kitchen:master Aug 29, 2013
@fnichol
Copy link
Contributor

fnichol commented Aug 29, 2013

All right, thank you @jrwesolo!

@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants