Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service / contract tests #4

Open
jinal--shah opened this issue Nov 5, 2018 · 2 comments
Open

Service / contract tests #4

jinal--shah opened this issue Nov 5, 2018 · 2 comments

Comments

@jinal--shah
Copy link
Contributor

jinal--shah commented Nov 5, 2018

I'm tempted to add some assurance tests for the included tools, specifically jq + aws cli - those form the expected contract for future aws_env releases, so we can move to semver and prepare to replace credstash with alternative secrets managers e.g. ssm param store, for v2.x.x

Then again, this container is just a bundle of 3rd party tools which they have already tested ... we don't have any code of our own as such, nor even a docker init entrypoint that might warrant testing.

We still want to avoid the situation though where a bundled tool is removed from the latest version of the image e.g. credstash may be getting dropped now, given AWS has cheaper alternatives e.g. SSM Parameter Store, even Secrets Manager ...

Instead of trying to test sprawling, 3rd party-maintained apps maybe we should version our own bundle semantically.

@jinal--shah
Copy link
Contributor Author

After discussion with @aries1980 (and previous discussions with @leventyalcin ) we think versioning is the way forward for this.

We'll address testing once we add bespoke code to the image e.g. it will be required when we introduce code to choose between different secrets managers backends for example

@jinal--shah
Copy link
Contributor Author

jinal--shah commented Nov 5, 2018

TODO:

  • add a note to the README that the semver tag must be used in preference to stable from now on.
  • consider tagging the docker image with additional major-only and major-minor-only tags as well, to allow consumers to peg to the latest major version, or minor version for a given major.
    e.g opsgang/aws_env:1.2.2, opsgang/aws_env:1.2, opsgang/aws_env:1 pointing to the same image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant