Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Process nodes in generators CTL when no variables are passed in #176

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Dec 19, 2024

Add processing of nodes when no variables are passed into CLI so the nodes get added into the store.

This added generator.process_nodes call that the generator.collect_data method typically handles, but since we're collecting data outside, .process_nodes was never called within infrahubctl.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/generator.py 0.00% 2 Missing ⚠️
@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
+ Coverage    66.22%   66.56%   +0.33%     
===========================================
  Files           76       81       +5     
  Lines         7031     7231     +200     
  Branches      1388     1410      +22     
===========================================
+ Hits          4656     4813     +157     
- Misses        1989     2035      +46     
+ Partials       386      383       -3     
Flag Coverage Δ
integration-tests 7.17% <0.00%> (?)
python-3.10 43.88% <0.00%> (-1.20%) ⬇️
python-3.11 43.88% <0.00%> (-1.20%) ⬇️
python-3.12 43.88% <0.00%> (-1.20%) ⬇️
python-3.13 43.88% <0.00%> (-1.20%) ⬇️
python-3.9 42.28% <0.00%> (-1.88%) ⬇️
python-filler-3.12 24.50% <0.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/generator.py 23.63% <ø> (+0.42%) ⬆️
infrahub_sdk/generator.py 35.52% <0.00%> (+0.46%) ⬆️

... and 42 files with indirect coverage changes

@FragmentedPacket FragmentedPacket merged commit f06fa55 into develop Jan 3, 2025
14 checks passed
@FragmentedPacket FragmentedPacket deleted the may-202412-generator-convert-fix branch January 3, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants