Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Remove the local validation of the query filters when calling client.filters() #9

Closed
dgarros opened this issue Sep 18, 2024 · 0 comments · Fixed by #41
Closed
Assignees
Labels
type/feature New feature or request

Comments

@dgarros
Copy link
Contributor

dgarros commented Sep 18, 2024

Component

Python SDK

Describe the Feature Request

Currently in the python SDK we are automatically validating the query filters passed to client.filters() based on the information provided in the schema.

This local validation has been the root cause of a few issues recently because the filters provided as part of the schema aren't 100% identical to the filters supported by the GraphQL api.

Since the GraphQL API will validate the query filters anyway the proposal is to completely remove the local validation of the filters as currently implemented.

In the future if we want to have some local validation, we should probably investigate how to retrive the graphql schema directly and do a validation of the graphql query based on the schema

Describe the Use Case

Improve the user experience and ensure that all filters available in the graphql api are available in the python SDK

Additional Information

No response

@dgarros dgarros added the type/feature New feature or request label Sep 18, 2024
@dgarros dgarros transferred this issue from opsmill/infrahub Sep 21, 2024
@dgarros dgarros self-assigned this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant