Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SchemasLoadAPI should not inherited from SchemaRoot but from BaseModel #3821

Closed
BeArchiTek opened this issue Jul 12, 2024 · 0 comments
Closed
Labels
group/backend Issue related to the backend (API Server, Git Agent) type/bug Something isn't working as expected

Comments

@BeArchiTek
Copy link
Contributor

Component

API Server / GraphQL

Infrahub version

0.15.0

Current Behavior

SchemasLoadAPI includes some redundant fields at the root of the object

version (string | null)
generics array<object>
nodes array<object>
extensions object
schemas* array<object>
  Items object
  version string
  generics array<object>
  nodes array<object>
  extensions object

Expected Behavior

SchemasLoadAPI should be only a list of Schemas (SchemaLoadAPI) without the extra field at the root of the model

Steps to Reproduce

  • With the 0.15.0, you can see the detail in http://localhost:8000/api/docs#/Schemas/

Additional Information

class SchemasLoadAPI(SchemaRoot):

class SchemasLoadAPI(SchemaRoot):
    schemas: list[SchemaLoadAPI]
@BeArchiTek BeArchiTek added the type/bug Something isn't working as expected label Jul 12, 2024
@dgarros dgarros closed this as completed Aug 26, 2024
@dgarros dgarros added this to the Infrahub - 0.16 milestone Aug 26, 2024
@dgarros dgarros added the group/backend Issue related to the backend (API Server, Git Agent) label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) type/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants