Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: data diff view on branch detail page has an approve button that should not be there #4094

Closed
wvandeun opened this issue Aug 13, 2024 · 0 comments
Labels
group/frontend Issue related to the frontend (React) type/bug Something isn't working as expected

Comments

@wvandeun
Copy link
Contributor

Component

Frontend UI

Infrahub version

0.16.0.dev0

Current Behavior

The data diff view on the branch detail page has an approve button that should not be there. This button is part of the proposed change process and should not be available on the branch detail page.
When you click on the button, you get an error message.

image

Expected Behavior

The button should not be there on the branch detail page, or it should be disabled.

Steps to Reproduce

  • spin up infrahub
  • create a branch
  • make a change in the branch (add a new tag)
  • navigate to the branch detail page in the frontend
  • click on diff, and then open the data tab

Additional Information

No response

@wvandeun wvandeun added the type/bug Something isn't working as expected label Aug 13, 2024
@dgarros dgarros added the group/frontend Issue related to the frontend (React) label Aug 13, 2024
@dgarros dgarros added this to the Infrahub - 0.16 milestone Aug 13, 2024
@pa-lem pa-lem closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/frontend Issue related to the frontend (React) type/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants