Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Be able to support number bigger/smaller than signed integer #4179

Closed
BeArchiTek opened this issue Aug 26, 2024 · 1 comment
Closed

feature: Be able to support number bigger/smaller than signed integer #4179

BeArchiTek opened this issue Aug 26, 2024 · 1 comment
Assignees
@LucasG0
Labels
group/backend Issue related to the backend (API Server, Git Agent) type/feature New feature or request type/newcomers Good for newcomers
Milestone
Infrahub - 0.16.1

Comments

@BeArchiTek
Copy link
Contributor

Component

API Server / GraphQL

Describe the Feature Request

Improve the Number attribute to support number bigger (or smaller) than a signed int.

Describe the Use Case

Be able to use 32-bits private ASN in a Number Pool

Additional Information

Maybe something to tackle with adding float into Number for #1945
@BeArchiTek BeArchiTek added type/feature New feature or request group/backend Issue related to the backend (API Server, Git Agent) labels Aug 26, 2024
@opsmill opsmill deleted a comment Aug 26, 2024
@opsmill opsmill deleted a comment Aug 26, 2024
@dgarros dgarros added this to the Infrahub - 0.16.1 milestone Aug 28, 2024
@dgarros
Copy link
Collaborator

dgarros commented Aug 28, 2024

Looks like the main limitation is coming from the GraphQL type that we are using : Int
Graphene also support another type BigInt that should fix this problem, it should be fairly easy to switch

@ogenstad ogenstad added the type/newcomers Good for newcomers label Sep 3, 2024
@exalate-issue-sync exalate-issue-sync bot added the state/planned This issue is planned to be worked on in an upcoming release. label Sep 9, 2024
@LucasG0 LucasG0 mentioned this issue Sep 9, 2024
Merged
@LucasG0 LucasG0 closed this as completed Sep 12, 2024
@exalate-issue-sync exalate-issue-sync bot removed the state/planned This issue is planned to be worked on in an upcoming release. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucasG0 LucasG0

Labels
group/backend Issue related to the backend (API Server, Git Agent) type/feature New feature or request type/newcomers Good for newcomers
Projects
None yet
Milestone
Infrahub - 0.16.1
Development

No branches or pull requests
4 participants
@dgarros @BeArchiTek @ogenstad @LucasG0