Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent forms from being closed if there are unsaved changes #4419

Merged
merged 14 commits into from
Sep 24, 2024
Merged

Prevent forms from being closed if there are unsaved changes #4419

merged 14 commits into from
Sep 24, 2024

Conversation

pa-lem
Copy link
Contributor

@pa-lem pa-lem commented Sep 23, 2024 •
edited
Loading

  • Prevent form to be closed if the form has been updated
image

@pa-lem pa-lem added type/feature New feature or request group/frontend Issue related to the frontend (React) labels Sep 23, 2024
@dgarros
Copy link
Collaborator

dgarros commented Sep 23, 2024

Could this one goes into stable to be included in 0.16.1 ?

@pa-lem pa-lem requested a review from bilalabbad September 23, 2024 12:37
bilalabbad
bilalabbad reviewed Sep 23, 2024
View reviewed changes
changelog/4419.added.md Outdated Show resolved Hide resolved
@pa-lem pa-lem force-pushed the ple-close-form-alert-IFC-687 branch from a6e5aa6 to 7469eba Compare September 23, 2024 12:53
@pa-lem pa-lem changed the base branch from develop to stable September 23, 2024 12:53
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Sep 24, 2024
@pa-lem pa-lem requested a review from bilalabbad September 24, 2024 15:52
@github-actions github-actions bot removed the group/backend Issue related to the backend (API Server, Git Agent) label Sep 24, 2024
bilalabbad
bilalabbad reviewed Sep 24, 2024
View reviewed changes
changelog/4419.added.md Outdated Show resolved Hide resolved
@bilalabbad bilalabbad changed the title Prevent form close after updating values Prevent forms from being closed if there are unsaved changes Sep 24, 2024
@pa-lem
Copy link
Contributor Author

pa-lem commented Sep 24, 2024

only nats is failing, will merge

@pa-lem pa-lem merged commit c0e3d8b into stable Sep 24, 2024
27 of 28 checks passed
@pa-lem pa-lem deleted the ple-close-form-alert-IFC-687 branch September 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilalabbad bilalabbad bilalabbad approved these changes

Assignees
No one assigned
Labels
group/frontend Issue related to the frontend (React) type/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pa-lem @dgarros @bilalabbad