Tasks pagination fix in proposed changes #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pa-lem
commented
Sep 24, 2024
pa-lem
commented
- Fixes the pagination in the tasks table for the proposed changes
pa-lem
added
type/bug
bilalabbad
reviewed
Sep 24, 2024
| @@ -125,10 +125,6 @@ export function Component() { | |||
|
|
|||
| const proposedChangesData = data?.[PROPOSED_CHANGES_OBJECT]?.edges?.[0]?.node; | |||
|
|
|||
| if (!proposedChangesData) { | |||
There was a problem hiding this comment.
why? if proposedchanges does not exist. We should do something (either redirect or display an error page)
…ahub into ple-task-pagination-IFC-724
bilalabbad
approved these changes
Sep 24, 2024
|
only nats is failing, will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.