Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: CoreAccountRole and CoreObjectPermission should be branch agnostic nodes #5110

Closed
wvandeun opened this issue Dec 2, 2024 · 2 comments · Fixed by #5121
Closed

bug: CoreAccountRole and CoreObjectPermission should be branch agnostic nodes #5110

wvandeun opened this issue Dec 2, 2024 · 2 comments · Fixed by #5121
Labels
group/backend Issue related to the backend (API Server, Git Agent) priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release type/bug Something isn't working as expected

Comments

@wvandeun
Copy link
Contributor

wvandeun commented Dec 2, 2024

Component

No response

Infrahub version

1.0.7

Current Behavior

When you create/modify/delete an account role in the main branch, then this change is not reflected in other existing branches in Infrahub.

When you create/modify/delete an object permission in the main branch, then this change is not reflected in other existing branches in Infrahub.

Expected Behavior

create/modify/delete actions on a CoreAccountRole should be reflected in all branches

create/modify/delete actions on a CoreObjectPermission should be reflected in all branches

Steps to Reproduce

  • spin up instance of Infrahub
  • create a new account group
  • create a new branch
  • switch back to the main branch
  • add a new role
  • assign it to the newly created group
  • add an object permission for a BuiltinTag
  • switch to the newly created branch
  • the role will not exist in the branch
  • rebase the branch
  • the role now exists in the branch

Additional Information

No response

@wvandeun wvandeun added type/bug Something isn't working as expected group/backend Issue related to the backend (API Server, Git Agent) labels Dec 2, 2024
@exalate-issue-sync exalate-issue-sync bot added the priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release label Dec 2, 2024
@ogenstad
Copy link
Contributor

ogenstad commented Dec 2, 2024

As per what we agreed upon previously this part is working as intended, the problematic part would be that queries for permissions should run in non isolation mode. I.e. a query on a branch should include updated permissions from the main branch. (similar to the auto rebase feature we had previously)

@ogenstad
Copy link
Contributor

ogenstad commented Dec 2, 2024

I think this is what we want instead: #5121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) priority/2 This issue stalls work on the project or its dependents, it's a blocker for a release type/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants