Skip to content

Commit f25f824

Browse files
update: add empty list parameter to decision methods in OptimizelyUserContextTest for consistency
1 parent a9ae805 commit f25f824

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

core-api/src/test/java/com/optimizely/ab/OptimizelyUserContextTest.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2286,7 +2286,7 @@ public void decideSync_featureTest() {
22862286
OptimizelyJSON variablesExpected = optimizely.getAllFeatureVariables(flagKey, userId);
22872287

22882288
OptimizelyUserContext user = optimizely.createUserContext(userId);
2289-
OptimizelyDecision decision = user.decideSync(flagKey);
2289+
OptimizelyDecision decision = user.decideSync(flagKey, Collections.emptyList());
22902290

22912291
assertEquals(decision.getVariationKey(), variationKey);
22922292
assertTrue(decision.getEnabled());
@@ -2316,7 +2316,7 @@ public void decideForKeysSync_multipleFlags() {
23162316
OptimizelyJSON variablesExpected2 = optimizely.getAllFeatureVariables(flagKey2, userId);
23172317

23182318
OptimizelyUserContext user = optimizely.createUserContext(userId, Collections.singletonMap("gender", "f"));
2319-
Map<String, OptimizelyDecision> decisions = user.decideForKeysSync(flagKeys);
2319+
Map<String, OptimizelyDecision> decisions = user.decideForKeysSync(flagKeys, Collections.emptyList());
23202320

23212321
assertEquals(decisions.size(), 2);
23222322

@@ -2382,7 +2382,7 @@ public void decideAllSync_allFlags() {
23822382
OptimizelyJSON variablesExpected3 = new OptimizelyJSON(Collections.emptyMap());
23832383

23842384
OptimizelyUserContext user = optimizely.createUserContext(userId, attributes);
2385-
Map<String, OptimizelyDecision> decisions = user.decideAllSync();
2385+
Map<String, OptimizelyDecision> decisions = user.decideAllSync(Collections.emptyList());
23862386
assertEquals(decisions.size(), 3);
23872387

23882388
assertEquals(
@@ -2468,7 +2468,7 @@ public void decideAllSync_ups_batching() throws Exception {
24682468
Map<String, Object> attributes = Collections.singletonMap("gender", "f");
24692469

24702470
OptimizelyUserContext user = optimizely.createUserContext(userId, attributes);
2471-
Map<String, OptimizelyDecision> decisions = user.decideAllSync();
2471+
Map<String, OptimizelyDecision> decisions = user.decideAllSync(Collections.emptyList());
24722472

24732473
assertEquals(decisions.size(), 3);
24742474

@@ -2489,7 +2489,7 @@ public void decideSync_sdkNotReady() {
24892489

24902490
Optimizely optimizely = new Optimizely.Builder().build();
24912491
OptimizelyUserContext user = optimizely.createUserContext(userId);
2492-
OptimizelyDecision decision = user.decideSync(flagKey);
2492+
OptimizelyDecision decision = user.decideSync(flagKey, Collections.emptyList());
24932493

24942494
assertNull(decision.getVariationKey());
24952495
assertFalse(decision.getEnabled());
@@ -2507,7 +2507,7 @@ public void decideForKeysSync_sdkNotReady() {
25072507

25082508
Optimizely optimizely = new Optimizely.Builder().build();
25092509
OptimizelyUserContext user = optimizely.createUserContext(userId);
2510-
Map<String, OptimizelyDecision> decisions = user.decideForKeysSync(flagKeys);
2510+
Map<String, OptimizelyDecision> decisions = user.decideForKeysSync(flagKeys, Collections.emptyList());
25112511

25122512
assertEquals(decisions.size(), 0);
25132513
}
@@ -2529,7 +2529,7 @@ public void decideSync_bypassUPS() throws Exception {
25292529
.build();
25302530

25312531
OptimizelyUserContext user = optimizely.createUserContext(userId);
2532-
OptimizelyDecision decision = user.decideSync(flagKey);
2532+
OptimizelyDecision decision = user.decideSync(flagKey, Collections.emptyList());
25332533
// should return variationId2 set by UPS
25342534
assertEquals(decision.getVariationKey(), variationKey2);
25352535

@@ -2562,7 +2562,7 @@ public void decideAsync_featureTest() throws InterruptedException {
25622562
user.decideAsync(flagKey, decision -> {
25632563
result[0] = decision;
25642564
latch.countDown();
2565-
});
2565+
}, null);
25662566

25672567
assertTrue(latch.await(1, java.util.concurrent.TimeUnit.SECONDS));
25682568
OptimizelyDecision decision = result[0];
@@ -2598,7 +2598,7 @@ public void decideAsync_sdkNotReady() throws InterruptedException {
25982598
user.decideAsync(flagKey, decision -> {
25992599
result[0] = decision;
26002600
latch.countDown();
2601-
});
2601+
}, Collections.emptyList());
26022602

26032603
assertTrue(latch.await(1, java.util.concurrent.TimeUnit.SECONDS));
26042604
OptimizelyDecision decision = result[0];
@@ -2627,7 +2627,7 @@ public void decideForKeysAsync_multipleFlags() throws InterruptedException {
26272627
user.decideForKeysAsync(flagKeys, decisions -> {
26282628
result[0] = decisions;
26292629
latch.countDown();
2630-
});
2630+
}, Collections.emptyList());
26312631

26322632
assertTrue(latch.await(1, java.util.concurrent.TimeUnit.SECONDS));
26332633
Map<String, OptimizelyDecision> decisions = result[0];
@@ -2700,7 +2700,7 @@ public void decideForKeysAsync_sdkNotReady() throws InterruptedException {
27002700
user.decideForKeysAsync(flagKeys, decisions -> {
27012701
result[0] = decisions;
27022702
latch.countDown();
2703-
});
2703+
},Collections.emptyList());
27042704

27052705
assertTrue(latch.await(1, java.util.concurrent.TimeUnit.SECONDS));
27062706
Map<String, OptimizelyDecision> decisions = result[0];
@@ -2719,7 +2719,7 @@ public void decideAllAsync_callback_exception() throws InterruptedException {
27192719
callbackExecuted[0] = true;
27202720
latch.countDown();
27212721
throw new RuntimeException("Test exception in callback");
2722-
});
2722+
}, Collections.emptyList());
27232723

27242724
assertTrue(latch.await(1, java.util.concurrent.TimeUnit.SECONDS));
27252725
assertTrue(callbackExecuted[0]);

0 commit comments

Comments
 (0)