Changing experimentKey and variationKey to null instead of an emptry string in emitNotificationCenterActivate

Author: yavorona

packages/optimizely-sdk/lib/core/event_builder/index.d.ts

@@ -23,7 +23,7 @@ interface ImpressionOptions {
   clientVersion: string;
   configObj: ProjectConfig;
   experimentId: string | null;
-  ruleKey: string;
+  ruleKey: string | null;
   flagKey: string;
   enabled: boolean;
   ruleType: string;

packages/optimizely-sdk/lib/optimizely/index.ts

@@ -339,13 +339,13 @@ export default class Optimizely {
     }
 
     const ruleType = decisionObj.decisionSource;
-    const experimentKey = decision.getExperimentKey(decisionObj);
-    const variationKey = decision.getVariationKey(decisionObj);
+    const experimentKey = decisionObj.experiment?.key ?? null;
+    const variationKey = decisionObj.variation?.key ?? null;
 
     let experimentId: string | null = null;
     let variationId: string | null = null;
 
-    if (experimentKey !=='' && variationKey !== '') {
+    if (experimentKey && variationKey) {
       variationId = projectConfig.getVariationIdFromExperimentAndVariationKey(configObj, experimentKey, variationKey);
       experimentId = projectConfig.getExperimentId(configObj, experimentKey);
     }
@@ -365,9 +365,9 @@ export default class Optimizely {
       logger: this.logger,
     };
     const impressionEvent = getImpressionEvent(impressionEventOptions);
-    const experiment = configObj.experimentKeyMap[experimentKey];
+    const experiment = experimentKey ? configObj.experimentKeyMap[experimentKey] : null;
     let variation;
-    if (experiment && experiment.variationKeyMap && variationKey !== '') {
+    if (experiment && experiment.variationKeyMap && variationKey) {
       variation = experiment.variationKeyMap[variationKey];
     }
     this.notificationCenter.sendNotifications(NOTIFICATION_TYPES.ACTIVATE, {