Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit glossary files on server #10

Closed
ageorgou opened this issue Jan 29, 2021 · 4 comments
Closed

Edit glossary files on server #10

ageorgou opened this issue Jan 29, 2021 · 4 comments
Labels
glossaries low priority remote Communication with the Oracc server

Comments

@ageorgou
Copy link
Contributor

Will require some authentication. See also using VS code over SSH.

@ageorgou ageorgou added the remote Communication with the Oracc server label Jan 29, 2021
@giordano
Copy link
Collaborator

giordano commented Apr 5, 2022

Using the above mentioned extension, we can edit glossary files in an easy way without needing anything extra from us. We may want to document the workflow, and perhaps require the extension when installing Nisaba, but apart from that there is nothing else we need to do to.

@giordano
Copy link
Collaborator

giordano commented Apr 21, 2022

For the record, in order to add a dependency on the Remote - SSH extension we need to list it under extensionDependencies in the package.json file.

For example:

diff --git a/package.json b/package.json
index 62e33b8..253659e 100644
--- a/package.json
+++ b/package.json
@@ -183,5 +183,8 @@
         "vscode-textmate": "^5.2.0",
         "webpack": "^5.50.0",
         "webpack-cli": "^4.7.2"
-    }
+    },
+    "extensionDependencies": [
+        "ms-vscode-remote.remote-ssh"
+    ]
 }

and this will appear in the "Dependencies" tab of info page of the Nisaba extension:
image

I can make a PR with the above change if this looks good.

@ageorgou
Copy link
Contributor Author

Looks good, should we add it now or wait until we use it more extensively (or add some instructions for setting up the connection to the server)?

@giordano
Copy link
Collaborator

There has been some work on glossary files in

I think the first big chunk of work on glossary files has been done. There is ongoing work in #108 for #11. However by re-reading the conversation above I think we may still want to make Remote - SSH a dependency of this package, I'll open a separate ticket for that, and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
glossaries low priority remote Communication with the Oracc server
Projects
None yet
Development

No branches or pull requests

3 participants