Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-sharing test namespace #436

Open
WilliamParker opened this issue Oct 4, 2019 · 1 comment
Open

Add node-sharing test namespace #436

WilliamParker opened this issue Oct 4, 2019 · 1 comment
Labels

Comments

@WilliamParker
Copy link
Collaborator

WilliamParker commented Oct 4, 2019

We currently don't have much testing around node sharing in the rules network despite a significant amount of work done in the compiler to support it. This came up recently with a fairly significant bug in issue 433. I propose adding a namespace for tests focused on testing node sharing, both on functional correctness when it is done and that we do in fact share nodes when we are intending to do so. We added a test for the particular case in issue 433 but there are likely other scenarios we should test that may or may not be related to that exact issue. This will have the added benefit of clearly establishing when we are and are not trying to share nodes, which I think is not well defined at present.

I'm currently planning to work on this in the near future but if anyone else is doing the same we should coordinate and make sure we're not duplicating work.

cc @EthanEChristian @mrrodriguez

@WilliamParker
Copy link
Collaborator Author

PR at #439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants