Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation that queries provide the correct parameters #454

Open
EthanEChristian opened this issue May 8, 2020 · 0 comments
Open

Add validation that queries provide the correct parameters #454

EthanEChristian opened this issue May 8, 2020 · 0 comments

Comments

@EthanEChristian
Copy link
Contributor

With the default implementation of the session(LocalSession), the way that query is implemented it currently expects the caller to provide the parameters that the query expects, without explicitly verifying that they have.

This can lead to odd behavior, as without all parameters provided to the query it will not be able to find the correct tokens in memory

With this issue, I want to:

  1. Add validation that that the parameters provided to the query contain keys only stipulated in the parameters of the query itself otherwise fail
  2. Update the documentation1 around the usage of query to be more explicit on the fact that the parameters to a query align to that of the bindings in the query constraints
@EthanEChristian EthanEChristian changed the title Add validate that queries provide the correct parameters Add validation that queries provide the correct parameters May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant