Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find way to add functions to listener protocol without breaking consumers #457

Open
WilliamParker opened this issue Jun 17, 2020 · 0 comments

Comments

@WilliamParker
Copy link
Collaborator

Previously when we've added functions to the listener protocols this results in breaking of consumers that implement them. This is annoying because many listeners only actually need meaningful implementations of a small number of these functions, and the rest of the functions shouldn't actually do anything beyond returning the existing value of the listener. The listener used for tracking fact insertions in all cases, including unconditional assertions, for inspection is a good example of this. Perhaps we could create a new macro that creates an implementation of a protocol, but supplies the implementation of just returning the listener for function implementations that are not specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant