remove workaround needed for JDK without JDK-8235908

Author: dougxc

sdk/mx.sdk/mx_sdk_vm.py

@@ -635,23 +635,6 @@ def jlink_has_save_jlink_argfiles(jdk):
     """
     return _probe_jlink_info(jdk, '.supports_JDK_8237467')
 
-def _jdk_omits_warning_for_jlink_set_ThreadPriorityPolicy(jdk): # pylint: disable=invalid-name
-    """
-    Determines if the `jdk` suppresses a warning about ThreadPriorityPolicy when it
-    is non-zero if the value is set from the jimage.
-    https://bugs.openjdk.java.net/browse/JDK-8235908.
-    """
-    if not hasattr(jdk, '.omits_ThreadPriorityPolicy_warning'):
-        out = mx.OutputCapture()
-        sink = lambda x: x
-        tmpdir = tempfile.mkdtemp(prefix='jdk_omits_warning_for_jlink_set_ThreadPriorityPolicy')
-        jlink_exe = jdk.javac.replace('javac', 'jlink')
-        mx.run([jlink_exe, '--add-options=-XX:ThreadPriorityPolicy=1', '--output=' + join(tmpdir, 'jdk'), '--add-modules=java.base'])
-        mx.run([mx.exe_suffix(join(tmpdir, 'jdk', 'bin', 'java')), '-version'], out=sink, err=out)
-        shutil.rmtree(tmpdir)
-        setattr(jdk, '.omits_ThreadPriorityPolicy_warning', '-XX:ThreadPriorityPolicy=1 may require system level permission' not in out.data)
-    return getattr(jdk, '.omits_ThreadPriorityPolicy_warning')
-
 def _read_java_base_hashes(jdk):
     """
     Read the hashes stored in the ``java.base`` module of `jdk`.
@@ -817,10 +800,7 @@ def _get_image_vm_options(jdk, use_upgrade_module_path, modules, synthetic_modul
                 mx.log('Adding -Djdk.graal.SystemicCompilationFailureRate=-1 VM option to image')
                 vm_options.append('-Djdk.graal.SystemicCompilationFailureRate=-1')
 
-    if use_upgrade_module_path or _jdk_omits_warning_for_jlink_set_ThreadPriorityPolicy(jdk):
-        vm_options.append('-XX:ThreadPriorityPolicy=1')
-    else:
-        mx.logv('[Creating JDK without -XX:ThreadPriorityPolicy=1]')
+    vm_options.append('-XX:ThreadPriorityPolicy=1')
 
     if jdk_supports_enablejvmciproduct(jdk):
         non_synthetic_modules = [m.name for m in modules if m not in synthetic_modules]