Skip to content

Commit c400090

Browse files
Enable and fix gate test for run-time debug info
1 parent ac8e19c commit c400090

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed

substratevm/src/com.oracle.objectfile/src/com/oracle/objectfile/elf/dwarf/DwarfInfoSectionImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -996,7 +996,7 @@ private int writeOpaqueType(DebugContext context, TypeEntry typeEntry, byte[] bu
996996
abbrevCode = AbbrevCode.TYPE_POINTER;
997997
log(context, " [0x%08x] <1> Abbrev Number %d", pos, abbrevCode.ordinal());
998998
pos = writeAbbrevCode(abbrevCode, buffer, pos);
999-
int pointerSize = dwarfSections.referenceSize();
999+
int pointerSize = dwarfSections.pointerSize();
10001000
log(context, " [0x%08x] byte_size 0x%x", pos, pointerSize);
10011001
pos = writeAttrData1((byte) pointerSize, buffer, pos);
10021002
log(context, " [0x%08x] type 0x%x", pos, refTypeIdx);

substratevm/src/com.oracle.svm.test/src/com/oracle/svm/test/debug/helper/test_runtime_compilation.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ def setUp(cls):
4343
set_up_test()
4444
gdb_delete_breakpoints()
4545
gdb_start()
46-
gdb_execute("set dwarf-type-signature-fallback main")
4746

4847
@classmethod
4948
def tearDown(cls):
@@ -136,7 +135,6 @@ def setUp(cls):
136135
gdb_delete_breakpoints()
137136
gdb_start()
138137
set_up_gdb_debughelpers()
139-
gdb_execute("set dwarf-type-signature-fallback main")
140138

141139
@classmethod
142140
def tearDown(cls):

substratevm/src/com.oracle.svm.test/src/com/oracle/svm/test/debug/helper/test_runtime_deopt.py

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,17 @@ def test_backtrace_with_deopt(self):
8585
backtrace = gdb_execute('backtrace 5')
8686
# check if eager deopt frame
8787
if 'EAGER DEOPT FRAME' in backtrace:
88-
self.assertIn('[EAGER DEOPT FRAME] com.oracle.truffle.runtime.OptimizedCallTarget::profiledPERoot', backtrace)
89-
self.assertIn('(deoptFrameValues=2, __0=com.oracle.svm.truffle.api.SubstrateOptimizedCallTarget = {...}, __1=java.lang.Object[5] = {...}) at OptimizedCallTarget.java', backtrace)
90-
self.assertIn('com.oracle.svm.truffle.api.SubstrateOptimizedCallTargetInstalledCode::doInvoke', backtrace)
88+
self.assertIn('in [EAGER DEOPT FRAME]', backtrace)
89+
self.assertIn('deoptFrameValues=2', backtrace)
90+
91+
# check if values are printed correctly and backtrace is not corrupted
92+
if 'SubstrateEnterpriseOptimizedCallTarget' in backtrace:
93+
self.assertIn('SubstrateEnterpriseOptimizedCallTarget = {...}, __1=java.lang.Object[5] = {...}', backtrace)
94+
self.assertIn('SubstrateEnterpriseOptimizedCallTarget::doInvoke', backtrace)
95+
else:
96+
self.assertIn('SubstrateOptimizedCallTarget = {...}, __1=java.lang.Object[5] = {...})', backtrace)
97+
self.assertIn('SubstrateOptimizedCallTargetInstalledCode::doInvoke', backtrace)
98+
9199
self.assertNotIn('??', backtrace)
92100
self.assertNotIn('Unknown Frame at', backtrace)
93101
else:
@@ -104,9 +112,13 @@ def test_opaque_types_with_shared_library(self):
104112

105113
# check backtrace
106114
backtrace = gdb_execute('backtrace 5')
107-
self.assertIn('com.oracle.truffle.runtime.OptimizedCallTarget::profiledPERoot', backtrace)
108-
self.assertIn('(this=<optimized out>, originalArguments=com.oracle.svm.core.option.RuntimeOptionKey = {...})', backtrace)
109-
self.assertNotIn('this=<unknown type in <in-memory@', backtrace)
115+
if 'SubstrateEnterpriseOptimizedCallTarget' in backtrace:
116+
self.assertIn('SubstrateEnterpriseOptimizedCallTarget::add_I_AAIIZ', backtrace)
117+
self.assertNotIn('<unknown type in <in-memory@', backtrace)
118+
else:
119+
self.assertIn('com.oracle.truffle.runtime.OptimizedCallTarget::profiledPERoot', backtrace)
120+
self.assertIn('(this=<optimized out>, originalArguments=com.oracle.svm.core.option.RuntimeOptionKey = {...})', backtrace)
121+
self.assertNotIn('this=<unknown type in <in-memory@', backtrace)
110122

111123

112124
# redirect unittest output to terminal

0 commit comments

Comments
 (0)