Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-46841] Include overview of resources in dashboard dump #3648

Closed
kkriske opened this issue Aug 5, 2021 · 2 comments
Closed

[GR-46841] Include overview of resources in dashboard dump #3648

kkriske opened this issue Aug 5, 2021 · 2 comments

Comments

@kkriske
Copy link
Contributor

kkriske commented Aug 5, 2021

Feature request

Please include the following information:

Is your feature request related to a problem? Please describe.
I can't get a clear overview of which resources are included in the image. The only thing I can see is a huge amout of byte arrays in the heap dump, which I assume are stored resources but that doesn't tell me anything.

Describe the solution you'd like.
Add a -H:+DashboardResources option, which adds a section to the dashboard dump like this:

"resource-breakdown": {
    "resource-size": [
        {
            "name" : "com/example/some/resource.txt"
            "size" : 50
        }
    ]
}

Which is similar to the current layout for code/heap size dumps.

Describe who do you think will benefit the most.
GraalVM users, developers of libraries and frameworks which depend on GraalVM.
Basically anyone who is concerned about size and wants to avoid any extra resources that may be included by config of dependencies etc.

Describe alternatives you've considered.
I can include an extra snippet in the image that dumps out all resource locations. Which should be possible now that resources are a filesystem in itself. But then I need a modified image.

Additional context.
I cannot help with the visualisation in the dashboard website. But I would suggest a tree-view folder structure (which would also make sense for the code size view, but that's a different issue).

I have made a quick & dirty implementation of such a visualisation for the code size dump already, as a poc:
image

Express whether you'd like to help contributing this feature
I can help with the implementation of the dump, but obviously there needs to be a consensus on the format first.

@fniephaus
Copy link
Member

Thanks for the suggestions! We're looking into tooling improvements for GraalVM Native Image and displaying information on included/embedded resources is an important aspect. At the moment, you can log all resources via -H:Log=registerResource: (see here) and the build output has also been extended with the number and bytes of embedded resources (see 5e652cd).

@fniephaus fniephaus changed the title Include overview of resources in dashboard dump [GR-46841] Include overview of resources in dashboard dump Jun 26, 2023
@fniephaus
Copy link
Member

We now have an option to export a list of all embedded resources in the JSON format. Oracle GraalVM's build reports will also include a resources overview table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants