Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missleading warning after the integration of proxy registration to the reflection config #9057

Closed
zakkak opened this issue Jun 6, 2024 · 4 comments

Comments

@zakkak
Copy link
Collaborator

zakkak commented Jun 6, 2024

Describe the issue
Since #8822 GraalVM will print the following warning when a project has a proxy-config.json file:

Warning: Option 'DynamicProxyConfigurationResources' is deprecated and might be removed in a future release. Please refer to the GraalVM release notes.

This warning is missleading as the user doesn't explicitly pass DynamicProxyConfigurationResources. Instead a warning indicating that proxy-config.json` has been deprecated would be more suitable.

cc @loicottet

Steps to reproduce the issue
Please include both build steps as well as run steps

  1. Create hello world project
  2. Create META-INF/native-image/proxy-config.json (containing [] is enough)
  3. Package project in a jar file
  4. Try to build a native image from the jar file

Describe GraalVM and your environment:

  • GraalVM version (latest snapshot builds can be found here), or commit id if built from source: 9c0a7a4
  • JDK major version: 23
  • OS: Fedora 40
  • Architecture: AMD64

More details
Using --verbose we see that the option is automatically passed to native-image

'-H:DynamicProxyConfigurationResources@jar:file:///home/zakkak/quarkus-runner.jar!/META-INF/native-image/proxy-config.json+api=META-INF/native-image/proxy-config.json'
@loicottet
Copy link
Member

Thanks for the report! We should indeed change this message.

@loicottet
Copy link
Member

Fixed by 5fc14c4

@zakkak
Copy link
Collaborator Author

zakkak commented Jun 26, 2024

Thank you @loicottet

@zakkak
Copy link
Collaborator Author

zakkak commented Jun 27, 2024

For future reference the PR fixing this is #9155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants