-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully enforce reusability in MP Metrics 1.1. support #1048
Conversation
…incorrectly ignored the reusability setting
The (tentative) changes to FT to make the automatically-created metrics reusable are because automatically-derived metric names come from the class name and method name of the annotated method. In the FT unit tests, the |
…ounter(String) method should retrieve an existing metric, regardless of reusability set in previously-stored metadata. The original test code should work; we need to work on the registry methods that accept a name so they do a look-up before trying to reregister the metric.
… comparing metadata instances
Note that the preceding changes to |
…registry.counter(name) method works correctly
…er(name) works correctly
… the requested metric instance (or create it if it's not already there)
The code that supports MP Metrics 1.1 does not fully enforce reusability. These changes correct that.
(This PR also addresses some unnecessary references to the internal bridging infrastructure which these classes did not need to use; they can and should depend directly on the MP metrics 1.1 artifacts.)
See issue #1046