-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MP quickstart GreetApplication#getClasses method for auto-discovery #1395
Remove MP quickstart GreetApplication#getClasses method for auto-discovery #1395
Conversation
…overy of resources
I don't think this change is good.
I liked the way the quickstart was explicit - you create an app that has resources (and you can add an additional app, that has different resources). Please let's talk about it before merging. |
@tomas-langer Adding multiple apps is not the norm. Developers with experience in JAX-RS would not normally do that. Now adding libraries with resources and expecting those to be part of your app is more common, in fact this is how this whole discussion started, from a developer question. Other MP implementations seem to favor scanning as well. |
One concrete use case that came up in email is the MP extension openapi-ui. For this to work if I do not think we do want to force developers to do dive into the internals of external JARs to make them work with our example code. |
In light of this discussion, I propose to remove the @tomas-langer Are you OK with this approach? |
Tomas reports he is OK with removing the application class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses #1380
Removing the
getClasses
method from an app class allows auto-discovery to find resources automatically. This change showcases this feature in the quickstart (and stand-alone quickstart) MP apps.