Wait for thread completion only if interrupted flag set #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et and it is still running. Some new tests. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…et and it is still running. Some new tests. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tjquinno
approved these changes
May 21, 2020
spericas
added a commit
to spericas/helidon
that referenced
this pull request
May 21, 2020
) * Wait for a thread to complete only if its interrupted flag has been set and it is still running. Some new tests. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Updated copyright header. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
added a commit
that referenced
this pull request
May 21, 2020
* Wait for thread completion only if interrupted flag set (#1843) * Wait for a thread to complete only if its interrupted flag has been set and it is still running. Some new tests. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Updated copyright header. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Updated copyright header. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for thread completion only if interrupted flag set. This is to accomodate a spec requirement that threads executing busy loops need to be waited for after interruption. The code for that was there but was also running for threads not in a busy loop, such as those waiting on I/O. The condition to execute this code has been strengthen. Should fix #1783.