Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security now has higer priority #2298

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Aug 28, 2020

Abac now correctly handles validator config

Security MP service must have higher priority than services exposing endpoints (such as metrics, health), so we can protect these endpoints.

In addition when an endpoint was protected using abac, each validator tried to read the configuration and time validator threw an exception.

Resolves #2296
Resolves #2297
For 1.x

Abac now correctly handles validator config
@tomas-langer tomas-langer added bug Something isn't working 1.x Issues for 1.x version branch labels Aug 28, 2020
@tomas-langer tomas-langer requested a review from Verdent August 28, 2020 21:28
@tomas-langer tomas-langer self-assigned this Aug 28, 2020
Copy link
Member

@Verdent Verdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer merged commit ac6f491 into helidon-io:helidon-1.x Aug 31, 2020
@tomas-langer tomas-langer deleted the 2297-abac-1x branch August 31, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Issues for 1.x version branch bug Something isn't working security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abac time fails even when not configured Security MP service not triggered for metrics
2 participants