Use CDI to instantiate Application classes to invoke getClasses #2325
Conversation
…pplication instances during OpenAPI processing Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
| Unmanaged.UnmanagedInstance<? extends Application> unmanagedInstance = unmanagedApp.newInstance(); | ||
| Application app = unmanagedInstance.produce().inject().postConstruct().get(); | ||
| unmanagedInstance.preDestroy().dispose(); | ||
| return Optional.of(app); |
There was a problem hiding this comment.
Since disposal will do nothing, this is probably OK, but it looks weird. I wonder if you can move this Unmanaged stuff elsewhere, like where you call something like getClasses() on the Application instance, and do the disposal afterwards. Like up around line 123 or so for example.
There was a problem hiding this comment.
It sounds as if your concern is that the use of the instance (the app) outlives the unmanagedInstance that gave rise to it.
I see how that does look a bit odd. But the app instance also outlives the code around line 123 and in fact is used not only in the same MPOpenAPIBuilder but also in a separate class OpenApiCdiExtension.
I'll take a look at refactoring things to address that admittedly odd-looking code without altering too much the way the consuming code operates. Thanks for the catch.
There was a problem hiding this comment.
Yeah, the main problem is that dependent objects that may get injected into the Application instance (and of course it's user-supplied so you don't have any control over it) may get flushed/released/disposed when that dispose() call is made. So you don't want them to go away obviously while the Application instance is in use somewhere.
There was a problem hiding this comment.
The latest push rearranges the code so it uses any unmanaged instance as much as needed, and only then disposes of it.
…ication class, we use the instance as much as we need and then dispose of it
2 participants
Resolves #2324
Originally, the OpenAPI code instantiated
Applicationclasses directly so as to invoke theirgetClassesmethod.This does not work if the
Applicationinjects a bean and uses the bean in thegetClassesmethod.This PR uses CDI's
Unmanagedconstructs to temporarily instantiate and inject eachApplicationclass, invokegetClasses, then dispose of the instance.Thanks to @ljnelson for the idea of the solution.