-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for HTTP compression in the webserver #2379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spericas
changed the title
Enable support for HTTP compression in the webserver
WIP: Enable support for HTTP compression in the webserver
Sep 22, 2020
spericas
changed the title
WIP: Enable support for HTTP compression in the webserver
Enable support for HTTP compression in the webserver
Sep 23, 2020
tomas-langer
requested changes
Sep 23, 2020
.../functional/mp-compression/src/main/java/io/helidon/tests/functional/mpcompression/Main.java
Outdated
Show resolved
Hide resolved
...p-compression/src/test/java/io/helidon/tests/functional/mpcompression/MpCompressionTest.java
Show resolved
Hide resolved
tests/functional/mp-compression/src/main/resources/META-INF/microprofile-config.properties
Outdated
Show resolved
Hide resolved
webserver/jersey/src/test/java/io/helidon/webserver/jersey/JerseySupportTest.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/WebServer.java
Outdated
Show resolved
Hide resolved
Closed
…support for gzip and deflate encodings. Some new tests to show how it works. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…dated. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…est. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
force-pushed
the
webserver-compression
branch
from
September 23, 2020 18:45
08fb803
to
41c5a2a
Compare
* Enable support for HTTP compression in the webserver. Netty provides support for gzip and deflate encodings. Some new tests to show how it works. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Support for enable-compression flag, set to false by default. Test updated. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * New functional test for HTTP compression in MP. Restored old Jersey test. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Some cleanup of pom and test files. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Changes for new test support. Signed-off-by: Tomas Langer <tomas.langer@oracle.com> Co-authored-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
requested changes
Sep 24, 2020
webserver/webserver/src/main/java/io/helidon/webserver/WebServer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for HTTP compression in the webserver. Netty provides support for gzip and deflate encodings. Some new tests for SE and MP.
Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com