-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for a max payload limit on client requests #2491
Conversation
…mit the payload sizes in client requests, with or without the use of chunked encoding. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. One thing that does stand out is: the header talks about "content" (Content-Length
), the error code mentions "payload" and various other things mention "entity". We might want to think about normalizing our nouns in this area.
It's a good point and I struggled with that too. If you search for HTTP error 413, it will be described as both "payload too large" and "entity too large", so they are partly to blame as well. |
New
max-payload-size
property in server's configuration to limit size of a client request's payload, using content length or chunked encoding. Default value for property is -1, no limit. Unit for size is bytes.