-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json stream writers #2523
Merged
Merged
Json stream writers #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Verdent
force-pushed
the
json-stream-writers
branch
from
November 12, 2020 09:30
9501f87
to
0bd1e9d
Compare
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
danielkec
reviewed
Nov 12, 2020
media/jackson/src/main/java/io/helidon/media/jackson/JacksonEsBodyStreamWriter.java
Outdated
Show resolved
Hide resolved
media/jsonb/src/main/java/io/helidon/media/jsonb/JsonbEsBodyStreamWriter.java
Outdated
Show resolved
Hide resolved
media/jsonb/src/main/java/io/helidon/media/jsonb/JsonbEsBodyStreamWriter.java
Outdated
Show resolved
Hide resolved
media/jsonp/src/main/java/io/helidon/media/jsonp/JsonpEsBodyStreamWriter.java
Outdated
Show resolved
Hide resolved
...ckstarts/helidon-quickstart-se/src/test/java/io/helidon/examples/quickstart/se/MainTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
danielkec
previously approved these changes
Nov 12, 2020
romain-grecourt
previously approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. How about application/x-ndjson
?; the snippet reported in the issue initially used it.
I spoke with @dalexandrov and we have decided to add also |
Signed-off-by: David Kral <david.k.kral@oracle.com>
Verdent
dismissed stale reviews from romain-grecourt and danielkec
via
November 18, 2020 10:46
2f84730
romain-grecourt
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1794
Fixes #1795