Reloadable WebServer TLS during runtime #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verdent
force-pushed
the
reloadableSslContext
branch
from
a794758 to
b2c677a
Compare
Signed-off-by: David Kral <david.k.kral@oracle.com>
Verdent
force-pushed
the
reloadableSslContext
branch
from
112dc55 to
c18eaea
Compare
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
webserver/webserver/src/main/java/io/helidon/webserver/HttpInitializer.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/HttpInitializer.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/NettyWebServer.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/WebServer.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/WebServer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Kral <david.k.kral@oracle.com>
|
Yes, those already connected are still working fine, but the new ones are validated against the new TLS. |
| * | ||
| * @param tls new TLS configuration | ||
| * @param socketName specific named socket name | ||
| * @throws IllegalStateException if the new tls is not enabled or currently set tls is null |
There was a problem hiding this comment.
Looking at the constructor for SockerConfig, we don't keep the WebServerTls so it's not symetrical :(
How about `if {@link WebServerTls#enabled()} returns {@code false} or if {@link SocketConfiguration#ssl()} returns {@code null}.
We should probably update the ssl configuration for 3.0 @tomas-langer thoughts ?
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
romain-grecourt
approved these changes
Apr 6, 2021
aseovic
pushed a commit
to aseovic/helidon
that referenced
this pull request
Apr 26, 2021
Reloadable WebServer TLS during runtime Signed-off-by: David Kral <david.k.kral@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2863