Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassCastException during Graal native image and ReST Client #2917

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

dansiviter
Copy link
Contributor

@dansiviter dansiviter commented Apr 6, 2021

I've had issues testing this locally. I can replicate the issue and the build gets further with these changes, but ultimately still fails but for another reason.

@dansiviter dansiviter changed the title Addresses #2913 ClassCastException during Graal native image and ReST Client Apr 6, 2021
@dansiviter
Copy link
Contributor Author

dansiviter commented Apr 7, 2021

I've updated the manual integration tests to trigger a int primitive @PathParam on the ReST Client which appears to run fine.

@@ -191,8 +191,9 @@ private static void testBean(int port, String jwtToken) {
// + JSON-B
invoke(collector, "Rest client JSON-B", "json-b", aBean::restClientJsonB);
// + query params
invoke(collector, "Rest client Query param long", "1020", () -> aBean.restClientQuery(1020L));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the message to reflect they're targeting the wrapper Objects and not the primitive type.

@romain-grecourt
Copy link
Contributor

/trigger

@romain-grecourt
Copy link
Contributor

/oca-checked

@m0mus
Copy link
Contributor

m0mus commented Apr 8, 2021

Fixes #2913

@dansiviter
Copy link
Contributor Author

Not sure why it's stating test failures. When I click on it it says BUILD SUCCESS in the log.

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer added the contribution A PR contributed from outside of Helidon team. label Apr 13, 2021
@tomas-langer tomas-langer merged commit 691d1d1 into helidon-io:master Apr 15, 2021
aseovic pushed a commit to aseovic/helidon that referenced this pull request Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution A PR contributed from outside of Helidon team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants