Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MicroProfile Long Running Actions #3016

Merged
merged 46 commits into from
Aug 27, 2021
Merged

MicroProfile Long Running Actions #3016

merged 46 commits into from
Aug 27, 2021

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented May 13, 2021 •
edited
Loading

Fixes #2340

@danielkec danielkec self-assigned this May 13, 2021
@danielkec danielkec added the MP label May 14, 2021
@danielkec danielkec linked an issue May 14, 2021 that may be closed by this pull request
MicroProfile LRA Support #2340
Closed
3 tasks
@danielkec danielkec added dependencies Pull requests that update a dependency file enhancement New feature or request lra labels May 18, 2021
@danielkec danielkec force-pushed the mp-lra branch 2 times, most recently from 011dcc9 to c57c44b Compare June 1, 2021 15:49
@danielkec danielkec changed the title WIP: MicroProfile Long Running Actions MicroProfile Long Running Actions Jun 1, 2021
@danielkec danielkec added the docs label Jun 1, 2021
ljamen
ljamen reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor edits.

docs/mp/lra/01_introduction.adoc Outdated Show resolved Hide resolved
docs/mp/lra/01_introduction.adoc Outdated Show resolved Hide resolved
docs/mp/lra/01_introduction.adoc Outdated Show resolved Hide resolved
docs/mp/lra/01_introduction.adoc Outdated Show resolved Hide resolved
docs/mp/lra/01_introduction.adoc Outdated Show resolved Hide resolved
docs/mp/lra/03_participant.adoc Outdated Show resolved Hide resolved
docs/mp/lra/03_participant.adoc Outdated Show resolved Hide resolved
docs/mp/lra/03_participant.adoc Outdated Show resolved Hide resolved
docs/mp/lra/03_participant.adoc Outdated Show resolved Hide resolved
docs/mp/lra/03_participant.adoc Outdated Show resolved Hide resolved
tomas-langer
tomas-langer requested changes Jun 7, 2021
View reviewed changes
bom/pom.xml Outdated Show resolved Hide resolved
dependencies/pom.xml Outdated Show resolved Hide resolved
examples/microprofile/lra/README.md Outdated Show resolved Hide resolved
microprofile/lra/client/core/pom.xml Outdated Show resolved Hide resolved
microprofile/lra/client/core/pom.xml Outdated Show resolved Hide resolved
...ient/spi/src/main/java/io/helidon/microprofile/lra/coordinator/client/CoordinatorClient.java Outdated Show resolved Hide resolved
...ient/spi/src/main/java/io/helidon/microprofile/lra/coordinator/client/CoordinatorClient.java Outdated Show resolved Hide resolved
microprofile/lra/client/spi/src/main/java/module-info.java Outdated Show resolved Hide resolved
microprofile/lra/client/spi/src/main/java/module-info.java Outdated Show resolved Hide resolved
microprofile/tests/tck/tck-lra/src/test/resources/logging.properties Outdated Show resolved Hide resolved
@danielkec
MicroProfile Long Running Actions
b4405bf 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec added 12 commits July 6, 2021 12:26
@danielkec
Switch to WebClient in coordinator client
d2e80c1 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Switch to WebClient in mock coordinator
99b7fc8 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Checkstyle
a185450 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Module structure
c798497 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Helidon SE LRA Coordinator
2f1be37 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Coordinator RC in retry mechanism
7994e15 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Coordinator client retry
9f0b7ae 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Spotbugs NP_NULL_ON_SOME_PATH
b8a7282 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Review issues
e517355 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Checkstyle
4816eae 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
MP LRA spec 1.0
c57db41 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Deps and spi cleanup
7aa2e16 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec added 10 commits August 9, 2021 11:27
@danielkec
Trace TckContextTests.testParentContextAvailable
0583404 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Trace 2 TckContextTests.testParentContextAvailable
d51b275 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Revert "Trace 2 TckContextTests.testParentContextAvailable"
20e0468 
This reverts commit d51b275.
@danielkec
Try jersey client
f7a5b55 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Fix BasicTest.jaxRsCompensate
b2646f8 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Longer coordinator timeout
11f1290 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Wait for coordinator
ea2cdc9 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Trace request filter
3466df6 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
More workers
0101483 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Cleanup
a466058 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec requested a review from tomas-langer August 12, 2021 17:02
tomas-langer
tomas-langer requested changes Aug 17, 2021
View reviewed changes
...arayana-client/src/main/java/io/helidon/lra/coordinator/client/narayana/LRAStatusReader.java Outdated Show resolved Hide resolved
lra/coordinator/client/narayana-client/src/main/java/module-info.java Show resolved Hide resolved
lra/coordinator/server/src/main/java/io/helidon/lra/coordinator/Link.java Outdated Show resolved Hide resolved
...ordinator/server/src/main/java/io/helidon/lra/coordinator/LraDatabasePersistentRegistry.java Show resolved Hide resolved
lra/coordinator/server/src/main/java/io/helidon/lra/coordinator/Participant.java Outdated Show resolved Hide resolved
microprofile/lra/jax-rs/src/main/java/module-info.java Show resolved Hide resolved
microprofile/lra/jax-rs/src/main/resources/META-INF/beans.xml Outdated Show resolved Hide resolved
...quillian/src/main/java/io/helidon/microprofile/arquillian/HelidonContainerConfiguration.java
@@ -16,6 +16,11 @@

package io.helidon.microprofile.arquillian;

import java.util.ArrayList;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain changes done to this module. Any change here can have unexpected impact on any TCK, so these should be handled with extreme care.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows tweaking config builder from Arquillian container events, it shouldn't affect other tcks https://github.com/oracle/helidon/blob/28c81fa4464e0a601539aa5fb3054ce7d041ca4e/microprofile/tests/tck/tck-lra/src/test/java/io/helidon/microprofile/lra/tck/CoordinatorDeployer.java#L39-L83

.../arquillian/src/main/java/io/helidon/microprofile/arquillian/HelidonDeployableContainer.java Outdated Show resolved Hide resolved
...tests/arquillian/src/main/java/io/helidon/microprofile/arquillian/HelidonMethodExecutor.java Outdated Show resolved Hide resolved
@danielkec
Review issues
dda1782 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Review issues #2
4b95245 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Review issues helidon-io#3
4bc305c 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Review issues helidon-io#4
4edb23d 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Scalable coordinator support
5eca38f 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec requested a review from tomas-langer August 19, 2021 09:15
@danielkec
Random ports in tests
5daee8e 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Feature catalogue and native image support
590285b 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
AOT doc
caca2f5 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
LRA client cleanup
707be49 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Context set fix
3069b38 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Use FT for retries in coordinator client
58c524e 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Test fix after coordinator client api change
d8c976a 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec merged commit 1cdf3c9 into helidon-io:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen left review comments

@tomas-langer tomas-langer tomas-langer approved these changes

@spericas spericas Awaiting requested review from spericas

Assignees

@danielkec danielkec

Labels
dependencies Pull requests that update a dependency file docs enhancement New feature or request lra MP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MicroProfile LRA Support
3 participants
@danielkec @tomas-langer @ljamen