Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE Config Profiles #3113

Merged
merged 11 commits into from
Jul 8, 2021
Merged

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Jun 15, 2021

Resolves #1416
Resolves #2609

Support for configuration profiles (what we used to call meta configuration).
Example
Updated guide
Updated configuration docs
(Fixed all configuration docs links)

Profile can be switched by config.profile or helidon.config.profile system property, by HELIDON_CONFIG_PROFILE environment variable.

@tomas-langer tomas-langer self-assigned this Jun 15, 2021
@tomas-langer tomas-langer added the enhancement New feature or request label Jun 15, 2021
spericas
spericas previously approved these changes Jun 18, 2021
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small updates, one question re: 'implementing the interface'. Is that the correct terminology?

docs/se/config/08_supported-formats.adoc Outdated Show resolved Hide resolved
docs/se/config/09_config-profiles.adoc Outdated Show resolved Hide resolved
docs/se/config/09_config-profiles.adoc Outdated Show resolved Hide resolved
docs/se/config/09_config-profiles.adoc Outdated Show resolved Hide resolved
docs/se/config/09_config-profiles.adoc Outdated Show resolved Hide resolved
docs/se/config/09_config-profiles.adoc Outdated Show resolved Hide resolved
docs/se/config/09_config-profiles.adoc Show resolved Hide resolved
@barchetta barchetta added this to the 2.4.0 milestone Jun 28, 2021
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer requested a review from ljamen June 30, 2021 11:13
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

@barchetta barchetta merged commit 76b7d56 into helidon-io:master Jul 8, 2021
@tomas-langer tomas-langer deleted the 1416-config-profiles branch July 11, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Helidon SE: Polling strategy of type watch is not supported Config Profiles
4 participants