Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust JSON timer histogram output using units set on the timer (1.x) #3133

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Adjust JSON timer histogram output using units set on the timer (1.x) #3133

merged 2 commits into from
Jun 18, 2021

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Jun 18, 2021

See #3088

For timers, the JSON output of the histogram data should use the timer's units (if any) to convert the values.

Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com

… set on the timer (1.x)

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno requested a review from spericas June 18, 2021 13:57
@tjquinno tjquinno self-assigned this Jun 18, 2021
@tjquinno tjquinno merged commit a0981d4 into helidon-io:helidon-1.x Jun 18, 2021
@tjquinno tjquinno deleted the metrics-units-1.x branch June 18, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants