Modified Jaeger logic to not close scopes before switching threads #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s problematic when running async operations (such as in auth) and continuing work on the request thread. Instead, provide our own implementation of ScopeManager that allows closing a scope from any thread, not just the one that created it. Some new tests. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
tjquinno
approved these changes
Jul 23, 2021
spericas
added a commit
to spericas/helidon
that referenced
this pull request
Aug 16, 2021
…s problematic when running async operations (such as in auth) and continuing work on the request thread. Instead, provide our own implementation of ScopeManager that allows closing a scope from any thread, not just the one that created it. Some new tests. (helidon-io#3207) Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> (cherry picked from commit f6c983f)
spericas
added a commit
that referenced
this pull request
Aug 16, 2021
…s problematic when running async operations (such as in auth) and continuing work on the request thread. Instead, provide our own implementation of ScopeManager that allows closing a scope from any thread, not just the one that created it. Some new tests. (#3207) Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> (cherry picked from commit f6c983f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified Jaeger logic to not close scopes before switching threads as this is problematic when running async operations (such as in auth) and continuing work on the request thread. Instead, provide our own implementation of
ScopeManagerthat allows closing a scope from any thread, not just the one that created it. Some new tests.Issue #3194
Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com