Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jaeger-client to 1.6.0 #3233

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Upgrade jaeger-client to 1.6.0 #3233

merged 3 commits into from
Aug 5, 2021

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Jul 29, 2021 •
edited
Loading

  1. Upgrade jaeger-client to 1.6.0. This results in an upgrade of libthrift to 0.14.1 since it is a transitive dependency of jaeger-client
  2. Move version management of okhttp3 and okio to dependencies/pom.xml
  3. Exclude bad dependency that was introduced in libthrift 0.14.0.

I have successfully built native-image for tests/integration/native-image/mp-1 and run it.

@barchetta barchetta requested a review from tomas-langer July 29, 2021 21:42
@barchetta barchetta self-assigned this Jul 29, 2021
@barchetta barchetta mentioned this pull request Jul 30, 2021
Closed
@barchetta barchetta mentioned this pull request Aug 2, 2021
Closed
23 tasks
tomas-langer
tomas-langer approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta merged commit e4974ae into helidon-io:master Aug 5, 2021
@barchetta barchetta deleted the upgrade-jaeger-client branch August 27, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@barchetta barchetta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @tomas-langer