Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade brave-opentracing to 1.0.0 #3252

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Upgrade brave-opentracing to 1.0.0 #3252

merged 2 commits into from
Aug 9, 2021

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Aug 5, 2021 •
edited
Loading

Upgrades brave-opentracing to 1.0.0.

I have successfully built native-image for tests/integration/native-image/mp-1 and run it.

@barchetta barchetta added tracing dependencies Pull requests that update a dependency file labels Aug 5, 2021
@barchetta barchetta self-assigned this Aug 5, 2021
@barchetta barchetta requested a review from tomas-langer August 5, 2021 23:08
tomas-langer
tomas-langer approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is introducing a small backward incompatibility due to module name change. Can only be part of 2.4.0

@barchetta barchetta merged commit a3c452f into helidon-io:master Aug 9, 2021
@barchetta barchetta mentioned this pull request Aug 16, 2021
Closed
23 tasks
@barchetta barchetta deleted the upgrade-brave-opentracing branch August 27, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@barchetta barchetta

Labels
dependencies Pull requests that update a dependency file tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @tomas-langer