-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebServer and WebClient race conditions fixed #3264
Merged
Verdent
merged 6 commits into
helidon-io:master
from
Verdent:webserver-keep-alive-handling
Sep 1, 2021
Merged
WebServer and WebClient race conditions fixed #3264
Verdent
merged 6 commits into
helidon-io:master
from
Verdent:webserver-keep-alive-handling
Sep 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webserver/webserver/src/main/java/io/helidon/webserver/ForwardingHandler.java
Outdated
Show resolved
Hide resolved
Verdent
force-pushed
the
webserver-keep-alive-handling
branch
from
August 12, 2021 12:31
7fb548b
to
f198d04
Compare
Fixes #3242 |
Verdent
force-pushed
the
webserver-keep-alive-handling
branch
from
August 16, 2021 07:32
f198d04
to
6f38ea4
Compare
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Verdent
force-pushed
the
webserver-keep-alive-handling
branch
from
September 1, 2021 11:01
9b2e29d
to
a2108ec
Compare
Signed-off-by: David Kral <david.k.kral@oracle.com>
tomas-langer
requested changes
Sep 1, 2021
webclient/webclient/src/main/java/io/helidon/webclient/RequestContentSubscriber.java
Outdated
Show resolved
Hide resolved
webclient/webclient/src/main/java/io/helidon/webclient/WebClientRequestBuilderImpl.java
Show resolved
Hide resolved
webclient/webclient/src/main/java/io/helidon/webclient/RequestContentSubscriber.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Kral <david.k.kral@oracle.com>
tomas-langer
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verdent
added a commit
to Verdent/helidon
that referenced
this pull request
Sep 1, 2021
) * Unhandled entity checking and Connection header setting Signed-off-by: David Kral <david.k.kral@oracle.com> (cherry picked from commit 7440ebc)
Verdent
added a commit
that referenced
this pull request
Sep 1, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Kral david.k.kral@oracle.com