Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MP config instead of Config.create() in MP components. #3290

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Use MP config instead of Config.create() in MP components. #3290

merged 2 commits into from
Aug 24, 2021

Conversation

tomas-langer
Copy link
Member

Resolves #3285
Related to #3286

Signed-off-by: Tomas Langer tomas.langer@oracle.com

@tomas-langer
Use MP config instead of Config.create() in MP conmponents.
9b4efaf 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer self-assigned this Aug 18, 2021
@tomas-langer tomas-langer mentioned this pull request Aug 18, 2021
Closed
@tomas-langer tomas-langer changed the title Use MP config instead of Config.create() in MP conmponents. Use MP config instead of Config.create() in MP components. Aug 18, 2021
@tomas-langer tomas-langer mentioned this pull request Aug 18, 2021
Merged
@tjquinno
Copy link
Member

Should we make a similar sort of change in service-common/rest-cdi HelidonRestCdiExtension#registerService? That code does the casting of MP Config to Helidon's Config itself, but it could instead use the utility method as in these changes.

@tomas-langer
Fix registry factory to handle MP config.
3c3f360 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member Author

Should we make a similar sort of change in service-common/rest-cdi HelidonRestCdiExtension#registerService? That code does the casting of MP Config to Helidon's Config itself, but it could instead use the utility method as in these changes.

It is probably a good way to go, as that would work even with a third party implementation of MP Config.

tjquinno
tjquinno approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I looked at all the changes, paying particular attention to the revisions in Micrometer integration.

@tjquinno tjquinno mentioned this pull request Aug 24, 2021
Merged
@tomas-langer tomas-langer merged commit bfa18bf into helidon-io:master Aug 24, 2021
@tomas-langer tomas-langer deleted the 3285-mp-config-create branch August 24, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

@spericas spericas Awaiting requested review from spericas

Assignees

@tomas-langer tomas-langer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should always use MP config in CDI extension
2 participants
@tomas-langer @tjquinno