Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double caching by calling Application methods in ResourceConfig #3340

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Avoid double caching by calling Application methods in ResourceConfig #3340

merged 1 commit into from
Sep 1, 2021

Conversation

spericas
Copy link
Member

Also prevents calling getClasses and getSingletons multiple times. Calling getSingleton more than once can be problematic.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

@spericas
Avoid double caching by calling Application methods in ResourceConfig.
c7023b9 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added the jax-rs JAX-RS and Jersey related issues label Aug 31, 2021
@spericas spericas added this to the 2.4.0 milestone Aug 31, 2021
@spericas spericas requested a review from tjquinno August 31, 2021 14:29
@spericas spericas self-assigned this Aug 31, 2021
tjquinno
tjquinno approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming existing tests would fail if caching does not happen exactly once.

@spericas spericas merged commit 03837f7 into helidon-io:master Sep 1, 2021
@spericas spericas mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

Assignees

@spericas spericas

Labels
jax-rs JAX-RS and Jersey related issues
Projects
Backlog
Archived in project
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@spericas @tjquinno